Follow ups after 1.1.0 release #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix `user.home` for diktat gradle plugin (attempt 2) * Move log4j into scope `test` (diktat-common, diktat-rules) * Remove deprecated properties of `DiktatExtension` * Bump default version of diktat-rules in build.gradle.kts
petertrr
force-pushed
the
bugfix/followup-1269
branch
from
a30d59d
to
092e043
Compare
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
============================================
+ Coverage 82.36% 82.37% +0.01%
Complexity 2550 2550
============================================
Files 105 105
Lines 7202 7196 -6
Branches 2020 2019 -1
============================================
- Hits 5932 5928 -4
+ Misses 351 350 -1
+ Partials 919 918 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Code style
🤣 |
orchestr7
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user.homefor diktat gradle plugin (attempt 2)test(diktat-common, diktat-rules)DiktatExtensionApparently ktlint still uses
--debugoption and we can keep it in our plugins for compatibilityThere is no need for us to have logging implementation in dependencies: for CLI it's now provided by ktlint (they depend on logback) and specific config should be provided with the launch command; for maven and gradle plugins there is a logger provided by the build tool itself.
This pull request closes #76, closes #1269