Add experimental, test, and custom to the list of ignored rule set ids
#1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set ids ### What's done: Additional rule set ids (available since KtLint 0.47) are now ignored, both via the `--disabled_rules` command-line argument, and via class path exclusions (Gradle plug-in). This change fixes behaviour described in #1559 with KtLint 0.47+.
0x6675636b796f75676974687562
requested review from
petertrr,
nulls and
orchestr7
0x6675636b796f75676974687562
added
the
plugins
Codecov Report
@@ Coverage Diff @@
## feature/ktlint-wrapper #1568 +/- ##
============================================================
+ Coverage 82.15% 82.18% +0.03%
- Complexity 2314 2315 +1
============================================================
Files 112 112
Lines 7849 7863 +14
Branches 2033 2033
============================================================
+ Hits 6448 6462 +14
Misses 481 481
Partials 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
petertrr
approved these changes
Nov 16, 2022
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
Show resolved
Hide resolved
nulls
approved these changes
Nov 16, 2022
0x6675636b796f75676974687562
deleted the
bugfix/andrey.shcheglov/gradle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Additional rule set ids (available since KtLint 0.47) are now ignored, both via the
--disabled_rulescommand-line argument, and via class path exclusions (Gradle plug-in).This change fixes behaviour described in #1559 with KtLint 0.47+.