Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in SARIF mode #479

Merged
merged 6 commits into from
Jan 23, 2023
Merged

Fixes in SARIF mode #479

merged 6 commits into from
Jan 23, 2023

Conversation

kgevorkyan
Copy link
Member

What's done:

  • Rework the logic of comparing the test file and its copy
  • Enable test for SARIF mode in fix plugin

### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
@kgevorkyan kgevorkyan marked this pull request as ready for review January 23, 2023 09:00
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #479 (b309ee3) into main (b00599a) will increase coverage by 0.25%.
The diff coverage is 71.87%.

@@             Coverage Diff              @@
##               main     #479      +/-   ##
============================================
+ Coverage     47.25%   47.50%   +0.25%     
- Complexity      154      158       +4     
============================================
  Files            53       53              
  Lines          1822     1846      +24     
  Branches        314      316       +2     
============================================
+ Hits            861      877      +16     
- Misses          831      837       +6     
- Partials        130      132       +2     
Flag Coverage Δ
unittests 47.50% <71.87%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlin/com/saveourtool/save/plugins/fix/FixPlugin.kt 59.59% <71.87%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

243 tests  ±0   219 ✔️ ±0   8m 50s ⏱️ -33s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 65a8662. ± Comparison against base commit b00599a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

243 tests  ±0   218 ✔️ ±0   8m 7s ⏱️ - 5m 10s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       1 ±0 

For more details on these failures, see this check.

Results for commit 65a8662. ± Comparison against base commit b00599a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

243 tests  ±0   219 ✔️ ±0   16m 33s ⏱️ - 4m 37s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 65a8662. ± Comparison against base commit b00599a.

♻️ This comment has been updated with latest results.

### What's done:
* fix test
@kgevorkyan kgevorkyan enabled auto-merge (squash) January 23, 2023 10:32
@kgevorkyan kgevorkyan merged commit 9074bba into main Jan 23, 2023
@kgevorkyan kgevorkyan deleted the bugfix/sarif-mode branch January 23, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants