Fix PATH lookup and command line for Windows OS #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 22, 2015 18:39
There were two problems when running the lib in windows: - PATH env variable was split only with ':' instead of ';' - Windows command line was broken due to path spaces and .exe suffix After this commit library can be successfully run in Windows OS. Tested on Windows 10 x64 with Nmap 7.
|
I've tested the library in windows and I've executed the following high-level scans without problems: GetAliveHosts |
|
thanks for your pull req. i'll review it asap. |
|
this will certainly need a repackage on pypi btw :) |
|
Sounds great! Any doubt, ping me. |
savon-noir
added a commit
that referenced
this pull request
Nov 26, 2015
Fix PATH lookup and command line for Windows OS
|
merci, super pull-req. ca fait du bien une petite contrib :) |
|
à l'occasion, je v repackager et je t'ajoute dans le changelog...je dois d'abord jeter un oeil à l'issue sur le deadlock. a bientot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems when running the lib in windows:
After this commit library can be successfully run in Windows OS.
Tested on Windows 10 x64 with Nmap 7.
On Linux, changes should not affect execution.