Fix excon and http adapters #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix multiple cookie headers support for excon and http adapter - fix SSLError error handling for http connector - add inegration tests for excon and http adapters
|
Hi @Bonias! Thanks for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that
exconandhttpadapters weren't read correctly cookies when they were set by multipleSet-Cookieheaders. This PR fixes that.I also added integration specs for
exconandhttpadapters (just copied httpclient_spec), because they were missing. I needed to make additional changes tohttpadapter to make "https requests raises when no certificate was set up" spec pass.I skipped "supports chunked response" spec - it is failing and I don't know what to do with it.