Don't convert port to string on Excon adapter #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since excon internally checks for an integer (https://github.com/excon/excon/blob/master/lib/excon/utils.rb#L29)
Hey, folks! I'm running into an issue with Savon (thus HTTPI) and Excon. I need to seet "omit_default_port: true" or my request fails. omit_default_port depends on the port being 80 or 443, as integers [https://github.com/excon/excon/blob/master/lib/excon/utils.rb#L29]. Since httpi converts to string, the check is never true and the option is ignored.
Any reason in particular for converting to string? Any idea on how to catch this in the specs? :)