Rework of timeout errors (part 3): extend all raised timeout exceptions with HTTPI::TimeoutError #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
August 23, 2018 17:34
Why: for better support of the floating point values in `read_timeout` and `open_timeout` options.
|
Waiting for release 2.4.4 be published before merging this PR. |
ioquatix
suggested changes
Oct 6, 2021
| @@ -48,6 +50,9 @@ def cert_directory | |||
| # @see HTTPI.request | |||
| def request(method) | |||
| _request { |options| @client.send method, options } | |||
| rescue EmHttpTimeoutError | |||
| $!.extend TimeoutError | |||
There was a problem hiding this comment.
It's better to just raise a new exception and if you want to know the source, use Exception#cause.
|
Can you please consider the feedback and rebase this on master? Thanks! |
|
I'm closing stale issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap adapter-specific timeout errors with a TimeoutError.
Source: #195