Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rack dependency #230

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Fix rack dependency #230

merged 2 commits into from
Dec 17, 2021

Conversation

tbolender
Copy link
Contributor

@tbolender tbolender commented Dec 17, 2021 •
edited
Loading

Make rack again an explicit dependency. Update readme accordingly.

Closes #229

olleolleolle
olleolleolle approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tbolender!

@olleolleolle
Copy link
Contributor

(Re-running the tests, since JRuby had a failure, seems like a flake.)

@olleolleolle olleolleolle merged commit a20e6cc into savonrb:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional dependency rack used internally
2 participants
@tbolender @olleolleolle