Fixing ssl so that cert and cert_key can be manually set

[mwagg]

Hi,

I'm getting my ssl key and certificate from an instance of OpenSSL::PKCS12 so I'm manually setting cert and cert_key on HTTPI::Auth::SSL. The code for the read side of these properties meant that unless cert_file is also set, they will always return nil. So when HTTPI::Auth::SSL.present? is called it returns false and ssl is not used for my connection.

I've fixed the readers and added a couple of tests to prove it works.

[tjh]

👍

This fix is correct and the tests are solid.

[rubiii]

failed to reference the commit, but it's merged. thanks for this and thanks for testing :)

[mwagg]

Sorry if I'm being dumb here, but what do you mean by failed to reference the commit?

[rubiii]

github automatically references commits in pull requests/issue when your commit message
includes "closes #49" for example. no big deal :)

[mwagg]

Ah well there was no issue for this. I had just fixed it in my fork which I am using in production and then sent the pull request with the commit. I will add an issue first if I do any more.

[rubiii]

actually, pull requests are issues. if you look at the issues you will see some with "code attached" which link to pull requests.

[rubiii]

released as v0.9.7.