Fixing ssl so that cert and cert_key can be manually set #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This fix is correct and the tests are solid. |
|
failed to reference the commit, but it's merged. thanks for this and thanks for testing :) |
|
Sorry if I'm being dumb here, but what do you mean by failed to reference the commit? |
|
github automatically references commits in pull requests/issue when your commit message |
|
Ah well there was no issue for this. I had just fixed it in my fork which I am using in production and then sent the pull request with the commit. I will add an issue first if I do any more. |
|
actually, pull requests are issues. if you look at the issues you will see some with "code attached" which link to pull requests. |
|
released as v0.9.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm getting my ssl key and certificate from an instance of OpenSSL::PKCS12 so I'm manually setting cert and cert_key on HTTPI::Auth::SSL. The code for the read side of these properties meant that unless cert_file is also set, they will always return nil. So when HTTPI::Auth::SSL.present? is called it returns false and ssl is not used for my connection.
I've fixed the readers and added a couple of tests to prove it works.