Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set query parameter of url on Request #66

Closed
wants to merge 1 commit into from
Closed

Allow to set query parameter of url on Request #66

wants to merge 1 commit into from

Conversation

rogerleite
Copy link
Member

req = HTTPI::Request.new("http://example.com")
req.query = "q=query"
req.query = {:q => "query"}
req.url.to_s # => "http://example.com?q=query"

During development of http_monkey, i think would be cool to have this feature.

req = HTTPI::Request.new("http://example.com")
req.query = "q=query"
req.query = {:q => "query"}
req.url.to_s  # => "http://example.com?q=query"
@rubiii
Copy link
Contributor

rubiii commented Nov 30, 2012

hey roger,

i haven't been able to take a look at this earlier, but i did now.
your patch looks good, so i merged it and pan to release it with v2.

http_monkey looks nice :)

thanks!

@rogerleite
Copy link
Member Author

Great! Don't forget to close when you merge.

@rubiii rubiii closed this Nov 30, 2012
@rogerleite
Copy link
Member Author

I think you forget to merge!

@rubiii
Copy link
Contributor

rubiii commented Nov 30, 2012

wrong pull request :) now it's in: 207791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants