-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rack adapter #75
Rack adapter #75
Conversation
looks great i think. i'll take a closer look at it later today. thank you very much! |
👍 Great work! I did some comments on little details. |
@rogerleite fixed all of them 😸 |
Doh... Travis reports it's broken due to rsa removal error :). No it's not ;) |
no idea how to trigger pull request builds 😢 but it works fine for me. |
@rubiii yep, they are in. I squashed commits – nobody wants to see the details of implementation history ;) |
got it 👍 thanks borris. |
@rogerleite do you want to merge this? i haven't seen your comments, so ... |
oh and we also need an update to the changelog plus documentation at http://httpirb.com |
I'll do that, np. But I think I'll handle that tomorrow already :) |
sure. good night ;) |
Rack adapter, perform internal direct middleware calls.
Thanks for applying the suggestions, great work @inossidabile 👍 @inossidabile, if you update documentation from httpirb.com, you can use edge branch. Guys, i will be back only on 7 Jan. Happy new year! |
@rogerleite thanks dude. happy new year 🚀 |
releaed with version 2.1.0. |
Rack adapter adds ability to perform internal direct middleware calls. Usage case:
If you are interested in merging this, I can add corresponding CHANGELOG entry and extend README description.