Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack adapter #75

Merged
merged 1 commit into from
Dec 28, 2012
Merged

Rack adapter #75

merged 1 commit into from
Dec 28, 2012

Conversation

inossidabile
Copy link

Rack adapter adds ability to perform internal direct middleware calls. Usage case:

HTTPI::Adapter::Rack.mount 'app', IntegrationServer::Application
result = HTTPI.get("http://app/path", :rack)

If you are interested in merging this, I can add corresponding CHANGELOG entry and extend README description.

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

looks great i think. i'll take a closer look at it later today. thank you very much!

@rogerleite
Copy link
Member

👍 Great work! I did some comments on little details.

@inossidabile
Copy link
Author

@rogerleite fixed all of them 😸

@inossidabile
Copy link
Author

Doh... Travis reports it's broken due to rsa removal error :). No it's not ;)

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

no idea how to trigger pull request builds 😢 but it works fine for me.
have the requested changes been added to the pull request? because i can see only one commit.
and somehow i didn't get any notifications about the comments.

@inossidabile
Copy link
Author

@rubiii yep, they are in. I squashed commits – nobody wants to see the details of implementation history ;)

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

got it 👍 thanks borris.

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

@rogerleite do you want to merge this? i haven't seen your comments, so ...

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

oh and we also need an update to the changelog plus documentation at http://httpirb.com
if anyone of you wants to do that, please go ahead. otherwise i'll try to do it after the merge.

@inossidabile
Copy link
Author

I'll do that, np. But I think I'll handle that tomorrow already :)

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

sure. good night ;)

rogerleite added a commit that referenced this pull request Dec 28, 2012
Rack adapter, perform internal direct middleware calls.
@rogerleite rogerleite merged commit 6aafc50 into savonrb:master Dec 28, 2012
@rogerleite
Copy link
Member

Thanks for applying the suggestions, great work @inossidabile 👍
@rubiii Changelog updated. 🚢

@inossidabile, if you update documentation from httpirb.com, you can use edge branch.

Guys, i will be back only on 7 Jan. Happy new year!

@rubiii
Copy link
Contributor

rubiii commented Dec 28, 2012

@rogerleite thanks dude. happy new year 🚀

@inossidabile inossidabile deleted the rack_adapter branch January 2, 2013 16:34
@rubiii rubiii mentioned this pull request Jul 20, 2013
27 tasks
@rubiii
Copy link
Contributor

rubiii commented Jul 22, 2013

releaed with version 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants