Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use of monkey-patched Object#blank? #972

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Jun 15, 2022

What kind of change is this?

bugfix

Did you add tests for your changes?

No, as at least eight existing tests cover this change.

Summary of changes

The Object#blank monkey-patch was removed in 0.9.10, but this usage remains. It's problematic, as the implementation can vary depending on whether the definition comes from nori or rails (among others). For instance, ' '.blank? is false under the implementation from nori, but true under the implementation from rails. I've refactored it to be consistent with nori, since that is an actual dependency of savon.

Other information

@olleolleolle olleolleolle merged commit 488c4ae into savonrb:master Jun 16, 2022
@olleolleolle
Copy link
Contributor

Thanks, this fixed a defect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants