Refactor use of monkey-patched Object#blank? #972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
bugfix
Did you add tests for your changes?
No, as at least eight existing tests cover this change.
Summary of changes
The
Object#blank
monkey-patch was removed in 0.9.10, but this usage remains. It's problematic, as the implementation can vary depending on whether the definition comes fromnori
orrails
(among others). For instance,' '.blank?
isfalse
under the implementation fromnori
, buttrue
under the implementation fromrails
. I've refactored it to be consistent withnori
, since that is an actual dependency ofsavon
.Other information