Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We are working on code which dynamically reads WSDL files using wasabi, and makes savon requests based on the content of the file. We identified the following changes to be required for us to do this:
:order!
attribute to the types hash, which specifies the order of the type elements as defined by the WSDL source file. This makes wasabi compatible with Ruby 1.8, and also consistent with Savon, which allows passing an:order!
attribute for Ruby 1.8 users to specify the order (as described in http://savonrb.com/#executing-soap-requests):nillable, :minOccurs, :maxOccurs
). This is in addition to the already-present:type
attribute.We have tested our changes against the wasabi specs, as well as the specs of savon and savon-multipart, and they all pass (on a local test machine).