Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered type elements #16

Merged
merged 4 commits into from
Jul 3, 2013
Merged

Ordered type elements #16

merged 4 commits into from
Jul 3, 2013

Conversation

leoping
Copy link

@leoping leoping commented Oct 12, 2012

Hello,

We are working on code which dynamically reads WSDL files using wasabi, and makes savon requests based on the content of the file. We identified the following changes to be required for us to do this:

  • Adding :order! attribute to the types hash, which specifies the order of the type elements as defined by the WSDL source file. This makes wasabi compatible with Ruby 1.8, and also consistent with Savon, which allows passing an :order! attribute for Ruby 1.8 users to specify the order (as described in http://savonrb.com/#executing-soap-requests)
  • Changed merging of type attributes logic so that subclass attributes are not overwritten by base class attributes
  • Added additional information about the type attributes: :nillable, :minOccurs, :maxOccurs). This is in addition to the already-present :type attribute.

We have tested our changes against the wasabi specs, as well as the specs of savon and savon-multipart, and they all pass (on a local test machine).

@rubiii
Copy link
Contributor

rubiii commented May 11, 2013

this should finally be solved by 4.0.0.

@rubiii
Copy link
Contributor

rubiii commented May 11, 2013

i would like to get rid of the order parameter for the next (probably major) savon release.
with the new code on master we should be able to properly determine the order of elements.
i don't think there are any tests for this right now, but i'll add it to some todo list.

sorry this hasn't been updated, but i really needed to get these changes out so we have a
somewhat sane architecture instead of xpath hell!

@leoping
Copy link
Author

leoping commented May 17, 2013

Thanks @rubiii, we'll try out the latest version soon. So 4.0.0 has addressed all 3 items mentioned above?

@rubiii
Copy link
Contributor

rubiii commented May 17, 2013

@leoping it's not ready yet, but i'm working on integration it into savon right now.

  • specifying the :order! should not be necessary after this.
  • regarding subclass-merging i need to look at your changes.
  • these will be used to determine the number of occurrences.

please follow #27 for updates and let me know if i'm missing something.

rubiii added a commit that referenced this pull request Jul 3, 2013
@rubiii rubiii merged commit 388737e into savonrb:master Jul 3, 2013
@ghost ghost assigned rubiii Jul 3, 2013
@rubiii
Copy link
Contributor

rubiii commented Jul 3, 2013

@leoping merged these changes as well. they're on master and planned to be released with wasabi v3.2.0.
please let me know if this works for you.

This was referenced Jul 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants