Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servicename: Implement the #servicename method to extract the service name from the wsdl. #22

Merged
merged 5 commits into from
Apr 21, 2013

Conversation

keltia
Copy link
Contributor

@keltia keltia commented Mar 14, 2013

Many WSDL files have a "name" attribute in the "definitions" part, expose it as "servicename".

@keltia
Copy link
Contributor Author

keltia commented Mar 14, 2013

Can you pull again please, just hooked it into Wasabi::Document which should be better.

@rubiii
Copy link
Contributor

rubiii commented Mar 14, 2013

great. i would just change one thing and that is the name of the method.
i think it should either be 'service_name' or maybe just 'name'. not sure about it.

@keltia
Copy link
Contributor Author

keltia commented Mar 15, 2013

I choose servicename to avoid using the very common word "name" (even though it is the "right" name of the attribute). If you prefer service_name, no issue with me :)

rubiii added a commit that referenced this pull request Apr 21, 2013
@rubiii rubiii merged commit 263b12c into savonrb:master Apr 21, 2013
@rubiii
Copy link
Contributor

rubiii commented Apr 21, 2013

this was added to v3.1.0.

@keltia keltia deleted the servicename branch April 21, 2013 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants