Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Wasabi::Parser#sections implementation using Enumerable#group_by #90

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Simplify Wasabi::Parser#sections implementation using Enumerable#group_by #90

merged 1 commit into from
Aug 4, 2020

Conversation

bvicenzo
Copy link
Contributor

@bvicenzo bvicenzo commented Aug 4, 2020

As suggest here it produces the same result and it simpler.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling eff8185 on bvicenzo:bv-parse-sections-refactor into e47045d on savonrb:master.

@bvicenzo bvicenzo mentioned this pull request Aug 4, 2020
Merged
@olleolleolle olleolleolle merged commit 028044e into savonrb:master Aug 4, 2020
olleolleolle
olleolleolle approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@olleolleolle
Copy link
Contributor

@bvicenzo Thanks for polishing!

@bvicenzo bvicenzo deleted the bv-parse-sections-refactor branch August 4, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvicenzo @coveralls @olleolleolle