Improve change directory performance #418
Comments
|
I have decided that it's not worth passing the heavyweight fields like |
sayanarijit
added a commit
that referenced
this issue
Dec 11, 2021
This PR breaks the custom layout renderer API by deprecating the following heavyweight fields in the Lua Context passed to the renderer functions. The following fields are being deprecated: - app.directory_buffer - app.history - app.last_modes However, there's no change in the Lua Context passed to the functions called via `CallLua*` messages. Closes: #418
sayanarijit
added a commit
that referenced
this issue
Dec 11, 2021
This PR breaks the custom layout renderer API by deprecating the following heavyweight fields in the Lua Context passed to the renderer functions. The following fields are being deprecated: - app.directory_buffer - app.history - app.last_modes However, there's no change in the Lua Context passed to the functions called via `CallLua*` messages. Closes: #418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The release v0.16.4 improved the performance of operating in a big directory using a plugin that reads the
directory_buffer.nodesfield (by caching it). By it came at cost. Every time when enter a big directory, it will freeze for a moment to cache the nodes, which isn't necessary if we aren't using plugins that read that specific expensive field.Let's not cache things unnecessarily and hide the
directory_bufferfield. It's already nullable. So, let's provide an option likepass_directoty_bufferwhich is disabled by default. Plugins that really need to read that field can set it totrue.The text was updated successfully, but these errors were encountered: