Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Error) could not enter" ...: Not a directory (os error 20)" #653

Closed
duganchen opened this issue Jul 17, 2023 · 0 comments · Fixed by #654
Closed

"Error) could not enter" ...: Not a directory (os error 20)" #653

duganchen opened this issue Jul 17, 2023 · 0 comments · Fixed by #654

Comments

@duganchen
Copy link
Contributor

The error message that gets shown when you press "l" on a regular file should, really, not be there.

It looks like this could be solved trivially with an isdir check in "fn enter", but my Rust isn't good enough to put in a PR.
@duganchen duganchen mentioned this issue Jul 17, 2023
Merged
sayanarijit added a commit that referenced this issue Jul 17, 2023
@sayanarijit
Silently fail to 'enter' regular files (#654)
567a620 
Silently fail to "Enter" regular files. Entering only makes sense for
directories.

This fixes
#653 (comment)

I don't know Rust at all, so I make no claims to the code quality. But I
have tested this change and it does work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Silently fail to 'enter' regular files duganchen/xplr
1 participant
@duganchen