Pass p parameter explicitly in "character,MgsaSets" function

[gokceneraslan]

p parameter cannot be set for the function with "character, MgsaSets" signature. See #7 (comment) and #7 for more details.

[gokceneraslan]

I'm not sure which default of p parameter to use. In some functions it's defined as:

p=seq(1 ,min(20,floor(length(sets)/3)), length.out=10)/length(sets)

and in others as

p=seq(min(0.1, 1/length(sets)), min(0.3, 20/length(sets)), length.out=10)

Second one was the default for character,MgsaSets so I kept it as is. You can reproduce the bug via following code:

nrow(mgsa(c("A", "B"), new("MgsaSets", sets=list(set1 = LETTERS[1:3], set2 = LETTERS[2:4])), p=0.4)@pPost)
# [1] 10

nrow(mgsa(c("A", "B"), list(set1 = LETTERS[1:3], set2 = LETTERS[2:4]), p=0.4)@pPost)
# [1] 1

[sba1]

Am 2017-04-03 13:35, schrieb Gökçen Eraslan:

p parameter cannot be set for the function with "character, MgsaSets" signature. See #7 (comment) [1] and #7 [2] for more details.

Thanks a lot! Could you also integrate this in a unit test? (your example in #7) An appropriate place could be: tests/testthat/test-mgsa.R

[gokceneraslan]

I added the test case as well.