Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcase problem #2

Closed
enderahmetyurt opened this issue Apr 11, 2014 · 7 comments
Closed

upcase problem #2

enderahmetyurt opened this issue Apr 11, 2014 · 7 comments

Comments

@enderahmetyurt
Copy link

Hey,
There is a problem with "i" character when upcasing it.

str = "içel"
str.upcase
str        #=> "IÇEL"

It should be "İÇEL".

@sbagdat
Copy link
Owner

sbagdat commented Apr 11, 2014

Are you sure? It is tested by me and rspec for many times. Please, write your complete class?

@sbagdat
Copy link
Owner

sbagdat commented Apr 11, 2014

A simple class I tested right now. It works properly

require "turkish_support"

class Test
  using TurkishSupport
  def hey(str)
    str.upcase
  end
end

Test.new.hey('içel')  #=> İÇEL

@enderahmetyurt
Copy link
Author

Sorry I am out of home. I will share with you a screenshot.

@sbagdat
Copy link
Owner

sbagdat commented Apr 11, 2014

As I mentioned in the readme, TurkishSupport uses refinements. So, you need
to use using TurkishSupport line. Look at this usage in terminal:

$ require 'turkish_support'
 => true
$ using TurkishSupport
 => main
$ "içel".upcase
 => "İÇEL"

On Fri, Apr 11, 2014 at 7:57 PM, Ender Ahmet Yurt
notifications@github.comwrote:

I run specs and you're right içel looks like after .upcase method İÇEL no
problem. However, on the terminal, it looks
[image: screen shot 2014-04-11 at 19 54 58]https://cloud.githubusercontent.com/assets/447588/2682388/4a289ffc-c19a-11e3-9882-167beb0fbf20.png


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-40225603
.

@enderahmetyurt
Copy link
Author

screen shot 2014-04-11 at 20 42 25

@marjinal1st
Copy link

Are you sure that your bash has no problem with encoding?

Using Ubuntu 13.10 AMD64, Ruby 2.0.0-p353 and Pry 0.9.12.4, got no problems here:

image

@sbagdat
Copy link
Owner

sbagdat commented Apr 11, 2014

@marjinal1st thanks, it is same to me.

@enderahmetyurt I think this is special to your bash. if you find any reason about the problem, please open the issue again. Thanks.

@sbagdat sbagdat closed this as completed Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants