Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sbb-action-group): add visual tests #2750

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Jun 13, 2024

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • add visual tests for sbb-action-group

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons changed the title test: add visual tests for action-group [WIP] test: add visual tests for action-group Jun 13, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 13, 2024
@github-actions github-actions bot temporarily deployed to pr2750 June 13, 2024 10:01 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title test: add visual tests for action-group test(sbb-action-group): add visual tests Jun 13, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the outcome seems right. Some little proposals to change.

src/elements/action-group/action-group.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/action-group/action-group.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/action-group/action-group.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 14, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DavideMininni-Fincons DavideMininni-Fincons merged commit ab940c4 into main Jun 14, 2024
25 of 26 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-action-group branch June 14, 2024 15:32
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants