-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(sbb-action-group): add visual tests #2750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideMininni-Fincons
requested review from
kyubisation and
jeripeierSBB
as code owners
June 13, 2024 07:57
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
Jun 13, 2024
DavideMininni-Fincons
changed the title
test: add visual tests for action-group [WIP]
test: add visual tests for action-group
Jun 13, 2024
github-actions
bot
added
the
pr: peer review required
A peer review is required for this pull request
label
Jun 13, 2024
DavideMininni-Fincons
changed the title
test: add visual tests for action-group
test(sbb-action-group): add visual tests
Jun 13, 2024
jeripeierSBB
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the outcome seems right. Some little proposals to change.
github-actions
bot
added
the
pr: lead review approved
Pull request has been approved by a lead review
label
Jun 14, 2024
jeripeierSBB
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-actions
bot
removed
the
pr: peer review required
A peer review is required for this pull request
label
Jun 14, 2024
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
diff-available
pr: lead review approved
Pull request has been approved by a lead review
pr: visual review required
preview-available
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preflight Checklist
Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
sbb-action-group
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information