Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sbb-teaser): add visual tests #2899

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

Note:
the two 'after' alignments are cropped at lower breakpoints (eg. storybook), so i decided to create a custom combinations of breakpoints/alignments.

src/elements/teaser/teaser.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/teaser/teaser.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/teaser/teaser.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/teaser/teaser.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2899 July 8, 2024 11:05 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 9, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 404bec8 into main Jul 9, 2024
23 of 24 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-teaser branch July 9, 2024 08:39
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants