JSON_TO_ABAP: fix compressed JSON array to sorted/hashed table keeping components problem #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perhaps move the CLEAR up to below code, to have less impact on performance
|
|
tried that at first but that is outside of the loop of the array items so it wouldn't work |
sbcgua
requested changes
Jul 9, 2024
|
Thx :-) i only noticed it because in abapgit we have "skip initial fields" set to true for some TABU entries and when pulling it to a new system the tables where completely messed up :-) @larshp once that is merged/fixed abapgit would need to also get the mirror updated or? Should i create an issue there too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces the issue that is tracked #181 and contains a fix proposal.