-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle non-recursive directory syntax #32
Comments
I think this behavior matches git's ignore behavior: diff --git a/codeowners/test_codeowners.py b/codeowners/test_codeowners.py
index 7a9172a..def241d 100644
--- a/codeowners/test_codeowners.py
+++ b/codeowners/test_codeowners.py
@@ -479,6 +479,14 @@ GO_CODEOWNER_EXAMPLES = [
# "bar[0-5].log": True,
},
),
+ ex(
+ name="non-recursive",
+ pattern="docs/*",
+ paths={
+ "docs/getting-started.md": True,
+ "docs/build-app/troubleshooting.md": True,
+ },
+ ),
] Passes Git's
|
Hmm, it does look like Github's behaviour doesn't match A I just spun up a test repo, I have a |
For added confusion, the Git docs also say:
However, the actual behaviour of Git does not match this:
So it looks like Github's codeowners behaviour is matching the Git docs, but is not matching the actual Git behaviour, so trying to test this by comparing it to |
The Github codeowners docs say:
However:
The text was updated successfully, but these errors were encountered: