Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans for Windows Build Support? #368

Closed
ermakov-oleg opened this issue Aug 5, 2024 · 0 comments
Closed

Plans for Windows Build Support? #368

ermakov-oleg opened this issue Aug 5, 2024 · 0 comments

Comments

@ermakov-oleg
Copy link
Contributor

Hi,

I noticed that the issue about Windows support for libpg_query has been closed (issue #44). Just curious if there are any plans to support Windows builds in the future.

Thanks for making such an awesome product!
@ermakov-oleg ermakov-oleg mentioned this issue Aug 5, 2024
Merged
chdsbd pushed a commit that referenced this issue Aug 5, 2024
@ermakov-oleg
Added support windows (#369)
3aedc07 
#368
I tried to build the CLI on a Windows GitHub runner and it seems like there are no problems.

I tested the built binary on one of the Windows machines:

```bash
PS C:\Users\...\Downloads> .\squawk-windows-x64.exe --version
squawk 1.1.2
PS C:\Users\...\Downloads> .\squawk-windows-x64.exe 'test.sql'
test.sql:1:0: warning: adding-field-with-default

   1 | ALTER TABLE foo ADD COLUMN bar TEXT NOT NULL DEFAULT "baz";

  note: Adding a field with a VOLATILE DEFAULT requires a table rewrite with an ACCESS EXCLUSIVE lock. In Postgres versions 11+, non-VOLATILE DEFAULTs can be added without a rewrite.
  help: Add the field as nullable, then set a default, backfill, and remove nullability.

find detailed examples and solutions for each rule at https://squawkhq.com/docs/rules
PS C:\Users\...\Downloads>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ermakov-oleg