Update Nix flake with newer nixpkgs version #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings in a newer version of nixpkgs with updates to the Rust toolchain and plenty of other changes.
Squawk isn't able to handle the newest 15-* version of libpg_query that is present in nixpkgs now. Because it is extracted from a newer version of PostgreSQL, I believe the abstract syntax tree that it generates is slightly different and Squawk isn't expecting those differences. For that reason, pin libpg_query to 13-* until that is addressed in Squawk. 13-2.1.0 comes from what libpg_query-sys, the Rust bindings to libpg_query is using. The issue requiring the `allowUnsupportedSystem` directive was fixed as part of NixOS/nixpkgs#179749 and is now no longer necessary.
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried building Squawk recently in the Nix development shell and was running into a
cargo buildissue due to an older rustc version coming from nixpkgs: "error[E0658]:let...elsestatements are unstable". I see that the rust-toolchain is now using 1.67.0 and nixpkgs is providing 1.61.0.I ran
nix flake updateto get newer pinned versions of nixpkgs and the flake-utils library (not really important for this problem). I also had to override the version of libpg_query that comes through nixpkgs because it isn't compatible with Squawk. Upon making these changes,nix developandnix buildwork correctly again.