Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional function about get the start vertex from the file #39

Closed
wants to merge 1 commit into from

Conversation

lxrzlyr
Copy link

@lxrzlyr lxrzlyr commented Dec 26, 2023

modified:     src/bfs.cc
modified:     src/command_line.h
modified:     src/benchmark.h

src/benchmark.h
src/bfs.cc
src/command_line.h
@sbeamer
Copy link
Owner

sbeamer commented Jan 3, 2024

As I discussed in #40, I will not accept this functionality into the code base for fear it might be abused leading to poor evaluations.

If this functionality were to be accepted, there are some ways to improve this pull request (PR). Please keep an eye on the differences it introduces, and make sure they are all necessary. In this case, it touches 874 lines, when the critical changes are only a few dozen. Most of those changes appear to be changes to the coding style and format. Those are not necessary to submit the change, and this repo mostly conforms to Google's C++ Style Guide. Additionally, one of those changes even disables all the kernels other than BFS. That would not be good for us to include by default.

@sbeamer sbeamer closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants