-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization and test infrastructure #12
Conversation
- Using Fortran/C++ for most of the L-moments calculations via lmom and TLMoments - Changes in these calculations yield differences less than 1e-7 with the original lmomco-based calculations so I'm adjusting the test tolerance
It's disruptive and pops up a window during testing. That just seems like a recipe for disaster.
Hi Doug, many thanks for your extensive PR. I have just updated a new version of the library that includes some of your mods (those related to the plotting function). I will now work on merging your fork. |
Great. Thanks! If you've got any questions or concerns, don't hesitate to ask. |
Hi Doug, I could finally find some time to work on your pull request. Since there were too many conflicts with my latest master version I did the merge by hand. Your changes are in the main branch now. I'm working now on the tests, since some of them are failing due to my last changes to the function ... Still struggling with the tests. I get no errors when ══ testthat results
|
I'm not quite sure why it failed, but likely my inclusion of |
I close this now as all the suggested commits (or most part of them) have been included or have been superseded in the development version of the package. |
I know this is a big pull request, but everything has been documented carefully below. Feel free to edit as makes sense.