Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the github workflow in CI and CD #1063
Split the github workflow in CI and CD #1063
Changes from all commits
033b40d
f89a91a
aaad036
fe86809
14cb7d4
4e9be3c
3b35f9c
3916b90
0a37af8
55587fb
a999891
1e0e73a
f08e7b5
5f8266d
b4bee53
4c6987b
c3b3b79
499410b
83a276f
79d3243
ca0b856
267e90c
659d42a
6f9c98a
e05d7df
f3a15bf
67bfef5
283fd87
6036a3b
aaec3f7
6958f94
8be7169
b472ab0
fc53abb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about testing in CD for more than only the oldest Python version we currently support? Ideally all but we could also limit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue against this since the purpose of CD is not a (max. board) compatibility test. One could do this in the CI workflow as it is preferable to let these things fail fast there. Doing it at both places just doubles the effort without a real gain. It is highly likely that if sth is failing due to the wrong Python version, it is affecting the "not slow" tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do that in the CD workflow as its purpose is a bit of a different one (computing max coverage, doc, etc.). Moreover, I think that it is very unlikely that there is a failure introduced due to Python version incompatibility which only occurs in the slow tests and not the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @michaeldeistler had a strong opinion against increasing the runtime of our CI. In theory (with unlimited runners) adding more Python versions to CI will not increase the runtime as they're running in parallel but in cases like the hackathon this can make a difference. I don't have a strong opinion where to do it and on how many versions but I would be in favor of testing more than just one version somewhere.
Github Actions also has the option to schedule Actions like cron jobs, e.g. to run on multiple versions at least once per day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a workflow that can be run manually to check all tests (or another marker) if desired
This file was deleted.