Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tutorial on flexible interface #1139

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Remove tutorial on flexible interface #1139

merged 2 commits into from
Apr 10, 2024

Conversation

michaeldeistler
Copy link
Contributor

The getting started tutorial uses the flexible interface anyways, so we no longer need the specific tutorial on the flexible interface.

Copy link
Contributor

@augustes augustes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - integrated in 00

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (0f0ee6e) to head (a235b0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   85.13%   77.07%   -8.06%     
==========================================
  Files          90       90              
  Lines        6652     6652              
==========================================
- Hits         5663     5127     -536     
- Misses        989     1525     +536     
Flag Coverage Δ
unittests 77.07% <ø> (-8.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

We could also remove the 00_getting_started.ipynb as it now seems to be a duplicate of 00_getting_started_flexible.ipynb, no?

@michaeldeistler
Copy link
Contributor Author

Good point @janfb! I removed both and will merge now.

@michaeldeistler michaeldeistler merged commit dda9c9d into main Apr 10, 2024
3 checks passed
@michaeldeistler michaeldeistler deleted the removetut branch April 10, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants