Fixes current density estimator bug #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 83.93% 74.23% -9.71%
==========================================
Files 90 90
Lines 6930 6931 +1
==========================================
- Hits 5817 5145 -672
- Misses 1113 1786 +673
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaeldeistler
approved these changes
May 7, 2024
| *sample_shape, | ||
| condition_batch_dim, | ||
| ) | ||
| + self.input_shape |
There was a problem hiding this comment.
thanks! Would
(*sample_shape, condition_batch_dim, *self.input_shape)also work? It's just a bit cleaner IMO.
|
Added tests that check if batched log_prob/sample will be the same as unbatched. Will merge after tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
Fixes #1154
TODO