Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for making orbit plots when we have a pl rv #332

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

sblunt
Copy link
Owner

@sblunt sblunt commented Feb 2, 2023

No description provided.

@semaphoreP
Copy link
Collaborator

Can you describe the bug and fix? I'm not sure what to be looking for.

@coveralls
Copy link

coveralls commented Jun 30, 2023

Pull Request Test Coverage Report for Build 5427784093

  • 29 of 37 (78.38%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 86.37%

Changes Missing Coverage Covered Lines Changed/Added Lines %
orbitize/plot.py 29 37 78.38%
Files with Coverage Reduction New Missed Lines %
orbitize/plot.py 2 80.97%
Totals Coverage Status
Change from base Build 5425350030: -0.05%
Covered Lines: 5152
Relevant Lines: 5965

💛 - Coveralls

@sblunt
Copy link
Owner Author

sblunt commented Jul 7, 2023

@semaphoreP the plotting code was failing when there is a secondary RV measurement in the data file. This fixes that failure.

@semaphoreP semaphoreP merged commit 5d86209 into main Jul 19, 2023
8 of 9 checks passed
@sblunt sblunt deleted the pl_rv_plotting_bugfix branch January 19, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants