Retry #70
Merged
Retry #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks for taking some time to look into that error. Just a thought, but what would you think about exposing the |
|
@DavisVaughan ended up merging your solution to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sboysel do you care if I merge this in? It just adds a retry to the core functionality, retrying 10 times if anything fails. This helps because fred's api seems to be fairly finicky. Even with 10 retries I can't consistently get all tests to pass (some are far more finicky than others), but this helps interactive use for sure.
You can focus on this line, the rest is roxygen2 redocumenting things in a slightly different way since it was updated:
https://github.com/sboysel/fredr/compare/retry?expand=1#diff-2eb905d49bb8a6719a6334b2a1b87a73R60