python 2.6

[nossal]

Little changes to work with python 2.6. I hope you don't mind.

[sbraz]

How about just using sys.version_info[0]? It seems to work for all versions. Can you also add Python 2.6 to .travis.yml and rebase the commits into one for clarity?

[sbraz]

Looking at the code for xml.etree, I see that getiterator will soon issue a warning. Can you wrap the call into something like this?

if sys.version < (2, 7):
    …

[sbraz]

The current master should work. I'll make a new release if you're happy with it.

[nossal]

Ok, thank you. I'll do a pull request with the suggested corrections.

[sbraz]

Did you see 8ee9c10? I don't think there is anything else to do, pymediainfo should now work with Python 2.6 :)

[nossal]

Wow, almost the same thing a did. Thank you!

[sbraz]

Yeah I wouldn't have noticed the extra whitespace at the end of the line without your PR, thanks and good luck with your old Python :D

[nossal]

Are you planning to make a new release soon?

[sbraz]

Yup, as I said, I'm just waiting for your approval of the changes.

On 20 Jul 2016 7:08 p.m., "Rodrigo Nossal" notifications@github.com wrote:

Are you planning to make a new release soon?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#27 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEnANI3XHhGSeSp9C7WRR5k9YUe5aHbbks5qXlYMgaJpZM4JQQf7
.

[nossal]

Works like a charm. Here is my ✔️

[sbraz]

And here is the new release:
https://github.com/sbraz/pymediainfo/releases/tag/v2.1.5 and https://pypi.python.org/pypi/pymediainfo

On 20 July 2016 at 19:33, Rodrigo Nossal notifications@github.com wrote:

Works like a charm. Here is my ✔️

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#27 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEnANDnWsvsLuxSjMewW-ksBJ6t1Ro0qks5qXlvagaJpZM4JQQf7
.