This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Implement GetGenericPortMappingEntry function #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the other MR! Do you want to rebase this branch on master and then I'll merge & release? |
maufl
force-pushed
the
implement-get-generic-port-mapping-entry
branch
from
c953c07
to
643ecdd
Compare
maufl
force-pushed
the
implement-get-generic-port-mapping-entry
branch
from
643ecdd
to
ce884c2
Compare
maufl
commented
Jan 18, 2020
| } | ||
| } | ||
|
|
||
| impl std::error::Error for GetGenericPortMappingEntryError { |
There was a problem hiding this comment.
I noticed that description is deprecated and Display should be used instead and returning None for cause/source is the default so this implementation contains nothing.
|
Done. Do you think introducing the PortMappingEntry struct is a good idea? |
Sure, I don't see any issues with it. |
|
Then I think you can merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the required functions for the GetGenericPortMappingEntry function. I'm not sure whether the new PortMappingEntry struct is a good idea as a return value, or whether all fields are ok (lease_duration could for example be a Duration).
This branch is based on the branch of my other PR, so I'd hold of reviewing it for now.