This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Allow WANIPConnection:2 in parse_service() #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some routers only advertise WANIPConnection v2 and not v1. In this case parse_service() simply returns None which eventually causes search_gateway() to fail. http://upnp.org/specs/gw/UPnP-gw-WANIPConnection-v2-Service.pdf Section 1.2 specifies that WANIPConnection v2 is compatible with v1. Allowing WANIPConnection:2 makes the library work correctly with wider range of routers (in particular, AmpliFi HD now works correctly).
|
Should we also add |
|
I thought about that and it should be fine, however I am not in a position to actually test it. My router advertises only the following services: https://gist.github.com/kayru/ce569fac7b86d65b03f1e629ab79a493 |
|
I'm looking at the spec right now, and there's no mention of WANPPPConnection:2. |
|
Thanks for the MR, I release 0.11.1 with this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some routers only advertise WANIPConnection v2 and not v1. In this case parse_service() simply returns None which eventually causes search_gateway() to fail.
http://upnp.org/specs/gw/UPnP-gw-WANIPConnection-v2-Service.pdf
Section 1.2 specifies that WANIPConnection v2 is compatible with v1.
Allowing WANIPConnection:2 makes the library work correctly with wider range of routers (in particular, AmpliFi HD now works correctly).
This addresses one of the issues described in #12