Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run as non-root #63

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Run as non-root #63

merged 1 commit into from
Jun 7, 2019

Conversation

DaniRey
Copy link
Contributor

@DaniRey DaniRey commented Jun 6, 2019

  • running docker as root can be problematic (one has root privileges on
    the host)
  • running docker as root is disallow in some environments
  • this adds a users sbtuser (to keep it separate from the deamon user
    sbt)
  • and switches to the user sbtuser
  • it changes the CMD to sbt

@DaniRey
Run as non-root
197ff80 
 - running docker as root can be problematic (one has root privileges on
 the host)
 - running docker as root is disallow in some environments
 - this adds a users sbtuser (to keep it separate from the deamon user
 sbt)
 - and switches to the user sbtuser
 - it changes the CMD to sbt
@hseeberger hseeberger merged commit d27f4a6 into sbt:master Jun 7, 2019
@hseeberger
Copy link
Member

Thanks!

@hseeberger hseeberger mentioned this pull request Jun 7, 2019
Closed
DaniRey added a commit to DaniRey/scala-sbt that referenced this pull request Jun 7, 2019
@DaniRey
Fixing regressions introduced with PR sbt#63
0b37f10 
 - reorganize Dockerfile
 - download and install sbt as root
 - create and switch to sbtuser
 - download and provide Scala
 - prepare sbt
 - fixes sbt#64
DaniRey added a commit to DaniRey/scala-sbt that referenced this pull request Jun 7, 2019
@DaniRey
Fixing regressions introduced with PR sbt#63
05a2dda 
 - reorganize Dockerfile
 - download and install sbt as root
 - create and switch to sbtuser
 - download and provide Scala
 - prepare sbt
 - fixes sbt#64
hseeberger pushed a commit that referenced this pull request Jun 7, 2019
@DaniRey @hseeberger
Fixing regressions introduced with PR #63 (#65)
07f670a 
- reorganize Dockerfile
 - download and install sbt as root
 - create and switch to sbtuser
 - download and provide Scala
 - prepare sbt
 - fixes #64
@francisdb francisdb mentioned this pull request Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniRey @hseeberger