Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local binary patches #43

Closed
wants to merge 3 commits into from
Closed

Support local binary patches #43

wants to merge 3 commits into from

Conversation

fommil
Copy link
Contributor

@fommil fommil commented Oct 14, 2017

#42

@fommil
Copy link
Contributor Author

fommil commented Oct 14, 2017

travis is failing because of a java 6 restriction.

@fommil
Copy link
Contributor Author

fommil commented Oct 14, 2017

this should probably take a comma separated list of jars (e.g. monkey patching zinc and sbt-io)

@fommil
Copy link
Contributor Author

fommil commented Oct 14, 2017

This works as a big hammer of monkeys... but it doesn't work for apps that do their own classpath bootstrapping inside (e.g. sbt). Those apps need to have their own concept of monkeys that get batched with their application layer classloaders.

I still think there is value in this PR, so if you like it, I hope you can merge it.

@SethTisue
Copy link
Member

travis is failing because of a java 6 restriction

perhaps #44 will help

@fommil fommil changed the title Monkeys Support local binary patches Mar 8, 2018
@fommil
Copy link
Contributor Author

fommil commented Mar 9, 2018

closed for #50

@fommil fommil closed this Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants