Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to GitHub Actions #70

Merged
merged 2 commits into from
May 17, 2021
Merged

switch to GitHub Actions #70

merged 2 commits into from
May 17, 2021

Conversation

nevillelyh
Copy link
Collaborator

No description provided.

@nevillelyh
Copy link
Collaborator Author

Looks like @eed3si9n setup the release credentials in Travis, we'll have to set them in GHA too?
Also it's still under com.cavorite, need to move to com.github.sbt?

@eed3si9n
Copy link
Member

Feel free to use com.github.sbt, but I feel like y'all been putting enough work to claim it's a com.spotify thing?

@nevillelyh
Copy link
Collaborator Author

@RustedBones WDYT? We can maybe merge this first and fix credentials before next release?

@RustedBones
Copy link
Collaborator

If moving to github actions, I would recommend sbt-github-actions. Had good experience with. It avoids to end up in a staled state, and benefit from new improvements when new containers or GH actions are released.

On the package naming, I would prefer moving the package under com.github.sbt. Can be done in a separated PR of course :)

@RustedBones
Copy link
Collaborator

@nevillelyh does this look good to you ?

@nevillelyh nevillelyh merged commit 98e190a into master May 17, 2021
@nevillelyh nevillelyh deleted the neville/gha branch May 17, 2021 23:09
@RustedBones
Copy link
Collaborator

RustedBones commented Sep 2, 2021

Hi @eed3si9n, sorry to bother you.
Can the PGP and Sonatype secrets be added for this repo. I'd like to make a new release under the sbt organisation.
My release attempt failed here

@eed3si9n eed3si9n mentioned this pull request Sep 3, 2021
@eed3si9n
Copy link
Member

eed3si9n commented Sep 3, 2021

@RustedBones Sounds good. I created an issue #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants