Use sbt-ci-release to publish to com.github.sbt
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2023
Closed
This was referenced Apr 7, 2023
dwijnand
reviewed
Apr 11, 2023
eed3si9n
reviewed
Apr 14, 2023
Comment on lines
+23
to
+30
| - name: Coursier Cache | ||
| id: coursier-cache | ||
| uses: coursier/cache-action@v6 | ||
|
|
||
| - name: Install Adoptium Temurin OpenJDK | ||
| uses: coursier/setup-action@v1 | ||
| with: | ||
| jvm: adoptium:8 |
There was a problem hiding this comment.
Scala caching (sbt etc) is now built into setup-java:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '8'
cache: 'sbt'
eed3si9n
requested changes
Apr 14, 2023
There was a problem hiding this comment.
These need to be fixed. Likely they are blocking the scripted tests:
$ rg "com\.dwijnand" .
./README.md
23: addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1")
./sbtdynver/src/sbt-test/dynver/multi-project/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/custom-version-string-0/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/versions/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/multi-build/bar/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/multi-build/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/custom-version-string/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/assert-tag-version/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/distance-separator/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
./sbtdynver/src/sbt-test/dynver/no-v-tag-prefix/project/plugins.sbt
2: case Some(x) => addSbtPlugin("com.dwijnand" % "sbt-dynver" % x)
|
Hey @mkurz do you want me to take this over? I randomly have a use case for the |
|
Sure, please take it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
@SethTisue @eed3si9n please add secrets and then we can give this a shot. Maybe tagging
v5.0.0-M4to see if publishing works?