Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LicenseDetection public and allow choosing license style #181

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Make LicenseDetection public and allow choosing license style #181

merged 5 commits into from
Apr 16, 2020

Conversation

alejandrohdezma
Copy link
Contributor

What has been done in this PR?

  • Make LicenseDetection public so it can be used outside of this plugin, by third-party integrations.
  • Change LicenseDetection#startYear to String so other values can be used (such as a year range).
  • Add LicenseStyle parameter to LicenseDetection.
  • Add new headerLicenseStyle setting to HeaderPlugin that LicenseDetection will use by default. It is backward compatible since the default value (Detailed) is also the default value of the different licenses constructors.

@hseeberger
Copy link
Member

Thanks!

Could you please explain how the change wrt. LicenseStyle affects usage?

Also, please take a look at the build failure.

@alejandrohdezma
Copy link
Contributor Author

Could you please explain how the change wrt. LicenseStyle affects usage?

Of course! For users that want to change the license style while still using the auto-detection feature, now they can just select the license style they want to use using the headerLicenseStyle setting.

Also, please take a look at the build failure.

Could you please re-launch the build, the only failures I see are related to failing downloads from maven central, which doesn't occur when running the build locally.

@hseeberger
Copy link
Member

Thanks. The build now succeeded. Good job!

Could you please update the documentation in the README wrt the changes.

@alejandrohdezma
Copy link
Contributor Author

Could you please update the documentation in the README wrt the changes.

Sorry it took so long 😓

Done in 7295d9c

@hseeberger hseeberger merged commit b73aff0 into sbt:master Apr 16, 2020
@hseeberger
Copy link
Member

Thanks! Nice contribution.

@ches
Copy link

ches commented Apr 19, 2020

This is nice. I just came to the README and followed it, only to find that headerLicenseStyle key doesn't exist—@hseeberger do you have a release planned?

@hseeberger
Copy link
Member

@ches not planned, but I'm cutting one right now ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants