-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LicenseDetection
public and allow choosing license style
#181
Conversation
This setting will allow automatically changing the license style when using auto-detection
Thanks! Could you please explain how the change wrt. LicenseStyle affects usage? Also, please take a look at the build failure. |
Of course! For users that want to change the license style while still using the auto-detection feature, now they can just select the license style they want to use using the
Could you please re-launch the build, the only failures I see are related to failing downloads from maven central, which doesn't occur when running the build locally. |
Thanks. The build now succeeded. Good job! Could you please update the documentation in the README wrt the changes. |
Sorry it took so long 😓 Done in 7295d9c |
Thanks! Nice contribution. |
This is nice. I just came to the README and followed it, only to find that |
@ches not planned, but I'm cutting one right now ;-) |
What has been done in this PR?
LicenseDetection
public so it can be used outside of this plugin, by third-party integrations.LicenseDetection#startYear
toString
so other values can be used (such as a year range).LicenseStyle
parameter toLicenseDetection
.headerLicenseStyle
setting toHeaderPlugin
thatLicenseDetection
will use by default. It is backward compatible since the default value (Detailed
) is also the default value of the different licenses constructors.