Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winsupport #27

Closed
wants to merge 9 commits into from
Closed

Winsupport #27

wants to merge 9 commits into from

Conversation

harshad-deo
Copy link

Adds support for building on windows using cmake and msbuild.

The only important difference is that it uses System.getProperties(...) to determine the operating system and architecture instead of uname. The other diffs are (mostly) due to the client project of the plugin being built with sbt 0.13.

@jodersky
Copy link
Member

jodersky commented Dec 1, 2017

Thanks for taking the time to work on this and contributing your changes back. Unfortunately I cannot merge this in its current state for a couple of reasons:

  • Using system properties to determine the OS works well, it is however generally not sufficient to determine the architecture type (see discussion here Add support for Windows #20). I would suggest the following compromise: use the properties to determine the OS, and in case it is windows use the properties to determine the architecture as well (I assume windows currently only really works on x86), if not use uname.
  • Please keep the ch.jodersky org and maven repo

@jodersky jodersky closed this May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants