consistently canonicalize paths #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this issue: sbt/sbt-jshint#33
|
Is there a particular reason why .getCanonicalPath() is used instead of .getAbsolutePath()? I have a subproject referenced via a symbolic link outside of the base directory of the main project. .getCanonicalPath() is resolving the symbolic link in a UNIX environment. This results in errors when attempting to map source files to their outputs, since the source files are not relative to the base directory. |
|
I don't remember the details about this bug fix since it's been a few months since then. I don't think there was any particular reason. I guess you should create an example project to reproduce the issue and create a separate bug report though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue:
sbt/sbt-jshint#33