Run options added to /etc/default/app_name from javaOptions in run #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,3 +20,4 @@ packageSummary := "Test debian package" | |||
| packageDescription := """A fun package description of our software, | |||
| with multiple lines.""" | |||
|
|
|||
| javaOptions in run ++= Seq("-d64") | |||
There was a problem hiding this comment.
Since this is in the etc script (and only for SystemV packages), should this instead be javaOptions in Debian or systemVJavaOptions?
Unless the setting is ubiquitous across platforms, I'd like to use a more specific name, I think....
|
May be when upstart and systemV will use same bash script we could add this options in bash-template? And then this will be really "javaOptions in run". |
|
Useless since #138 I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #82 for sysvinit.