Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix issue #135: use Java7 nio POSIX permissions instead of forking and running chmod. #142

Closed
wants to merge 1 commit into from

Conversation

hootsuitemike
Copy link

This is an attempt to fix issue #135 by using the Java7 POSIX permissions interface in nio.

@muuki88
Copy link
Contributor

muuki88 commented Jan 30, 2014

Looks correct. Do you have any benchmarks? Currently we still support java 6, @jsuereth got the last word on this.

@hootsuitemike
Copy link
Author

I couldn't figure out how to run any of the test projects. Or even build the plugin itself to test with our project. :)

@muuki88
Copy link
Contributor

muuki88 commented Jan 30, 2014

set sbtVersion in Global := "0.13.1"
set scalaVersion in Global := "2.10.3"
publish-local
// scripted #if you want to run the automated tests

Then you will have a 0.6.3-<git-sha> in your local .ivy2 repository. Add this as dependency to your project and run.

@jsuereth
Copy link
Member

jsuereth commented Feb 1, 2014

I'd love to be able to merge this, but we need ot stay Java6 compliant still. Maybe we can put this in a branch. I think just merging chmod commands into as few as possible may be a temporary alternative. OR if you know of a Java7 IO backport....

@muuki88
Copy link
Contributor

muuki88 commented Feb 1, 2014

Sounds like a plan to gather java7 PRs in a separate branch. Still I wonder about the performance increase.

@muuki88 muuki88 added the debian label Feb 4, 2014
@muuki88
Copy link
Contributor

muuki88 commented Feb 18, 2014

I will merge this in a wip/java-7 branch.

@hootsuitemike
Copy link
Author

This patch will not work as it stands, I still need to translate from "755" style permissions to "rwxr-xr-x" style permissions which is what the Java7 API expects. Sorry I haven't had time to update the patch.

@muuki88
Copy link
Contributor

muuki88 commented Feb 18, 2014

No problem, thanks for your time :)

@muuki88
Copy link
Contributor

muuki88 commented Nov 3, 2014

@hootsuitemike your pr is still valid :) Would you like to give him the last touch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants