Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version #43

Closed
SethTisue opened this issue Sep 9, 2021 · 6 comments · Fixed by #46
Closed

Publish new version #43

SethTisue opened this issue Sep 9, 2021 · 6 comments · Fixed by #46

Comments

@SethTisue
Copy link
Member

SethTisue commented Sep 9, 2021

(now that #42, most notably, has landed)

what needs to be done here is replace bintray-based publishing with publishing to Sonatype (probably sbt-ci-release, which is pretty standard these days)

volunteer? (if you look around in sbt/sbt-* you can probably find other such PRs you could copy/adapt)

also we may need help from @eed3si9n setting up the needed publishing secrets

@SethTisue SethTisue self-assigned this Sep 9, 2021
@SethTisue SethTisue removed their assignment Sep 10, 2021
@sbly
Copy link
Contributor

sbly commented Sep 10, 2021

Can I help with this? The next release should be 0.5.0 right?

@SethTisue
Copy link
Member Author

Can I help with this?

Yes please! If you can PR the sbt-bintray -> sbt-ci-release changeover, Eugene should be able to get the publishing secrets set up so we can publish from CI just by pushing a tag.

The next release should be 0.5.0 right?

Maybe we should just go 1.0.0 at this point, since the plugin isn't changing much? (Not that it really matters, I don't think.)

@andrewinci
Copy link

Hello, is there any update on when the new release will be published? thank you :)

@SethTisue
Copy link
Member Author

@eed3si9n I've approved #46. Maybe you could give it a once-over and if it LGTY, merge it and add the publishing secrets to GitHub Actions?

@eed3si9n
Copy link
Member

eed3si9n commented Dec 4, 2021

Yea. That build needs a bit more work. ppl should copy-paste from an existing build that already works like https://github.com/sbt/sbt-jacoco/blob/v3.4.0/build.sbt

@eed3si9n eed3si9n reopened this Dec 4, 2021
eed3si9n added a commit to eed3si9n/sbt-proguard that referenced this issue Dec 4, 2021
eed3si9n added a commit to eed3si9n/sbt-proguard that referenced this issue Dec 4, 2021
@eed3si9n
Copy link
Member

eed3si9n commented Dec 4, 2021

https://github.com/sbt/sbt-proguard/releases/tag/v0.5.0.

https://repo1.maven.org/maven2/com/github/sbt/sbt-proguard_2.12_1.0/0.5.0-M1/ is already up for testing. 0.5.0 should sync to Maven Central shortly.

@eed3si9n eed3si9n closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants