Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade default proguard version to 6.2.2 #35

Merged
merged 4 commits into from
Jul 30, 2020

Conversation

mpollmeier
Copy link
Contributor

Which isn't three years old and also supports java >= 9
Doesn't seem to cause any issues in our builds.

@mpollmeier
Copy link
Contributor Author

Not sure what's wrong with the travis build, specifying the dist in travis.yml didn't help...
It's certainly not broken by this PR or #34.

@maximskripnik
Copy link

@mpollmeier
Copy link
Contributor Author

@maximskripnik thank you that was it. I had only tried dist: xenial before.
Also applied to #34

Ready to merge now.

@azolotko
Copy link
Contributor

What's preventing this PR from being merged?

@lassebn
Copy link

lassebn commented May 1, 2020

+1 for getting this merged 🙏

@azolotko azolotko mentioned this pull request Jul 25, 2020
@pvlugter
Copy link
Member

Hi @mpollmeier. Sorry, I haven't been watching this repo for some time, and we haven't been using Proguard on any projects. If anyone that is actively using the plugin is interested in maintaining, improving, reviewing pull requests, making releases, and so on, that would be great.

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvlugter pvlugter merged commit 4747a1f into sbt:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants