Choose the correct groupId for proguard #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
1 similar comment
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
pvlugter
approved these changes
Jul 31, 2020
| private def groupId(proguardVersionStr: String): String = | ||
| "^(\\d+)\\.".r | ||
| .findFirstMatchIn(proguardVersionStr) | ||
| .map(_.group(1).toInt) match { |
There was a problem hiding this comment.
I think sbt has some built-in version parsing now, although maybe not available for sbt 0.13 if this plugin is still cross-compiled.
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupId for Proguard 7.0.0 has been updated to
com.guardsquarehttps://bintray.com/guardsquare/proguard/com.guardsquare%3Aproguard-base/7.0.0