Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create symbolic links to api docs for 1.x and 1.x-beta docs #42

Merged
merged 2 commits into from
Oct 23, 2017

Conversation

dec5e
Copy link

@dec5e dec5e commented Oct 14, 2017

Now all the links in 1.x reference are broken :(

Here I create symbolic links to latest folder-version with API documentation available. It was done same way for v0.13 so I guess it's a proper way of fixing for v1.x as well.

@dec5e
Copy link
Author

dec5e commented Oct 16, 2017

@eed3si9n could you check this please?

@eed3si9n
Copy link
Member

Looks good. Thanks for the fix.

@eed3si9n eed3si9n merged commit b64a5d3 into sbt:master Oct 23, 2017
@dec5e
Copy link
Author

dec5e commented Oct 24, 2017

@eed3si9n 1.x/api was removed in 7fa1fcf#diff-f548793f434499330d41bca3c92eaa34 so now API links are again broken for v1.x

@dec5e dec5e deleted the 1.x_fix_api_links branch October 24, 2017 06:47
@eed3si9n
Copy link
Member

See https://github.com/sbt/website/blob/1.x/project/Docs.scala#L291

symlink(s"../$targetSbtFullVersion/api/", apiLink, s.log)

@dec5e
Copy link
Author

dec5e commented Oct 26, 2017

Thanks for pointing to correct place to fix this, created new PR for fixing "1.x" symlinks: sbt/website#530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants