Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get fullName post flatten, to get flatten names #1244

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 1, 2023

The reason this doesn't affect Scala 3 is because Scala 3 calls the zinc callback to register products during it's last, JVM bytecode emitting, phase. That affects pipelining, but I left problem for another day. Meanwhile, I found that the name is changed, in both compilers, in the "flatten" phase, so if I phase travel to that phase, getting the name (which is a recursive emission, through the ownership chain) will do the necessary "compatify" of long names.

Initially I tried compacting the name we already had, but the names didn't line up, because it was compacting the final name, rather than one of the owner names (as well as duplicating the implementation of compatify). That's also why I'm introducing checkProductsExist - to assert not only that the metadata matches the test expectations, but also the metadata matches the filesystem.

@dwijnand dwijnand linked an issue Sep 1, 2023 that may be closed by this pull request
@dwijnand dwijnand marked this pull request as ready for review September 2, 2023 09:57
@lrytz
Copy link
Contributor

lrytz commented Sep 4, 2023

@eed3si9n
Copy link
Member

I am planning to release 1.9.x soon, so I'll merge this as-is.

@SethTisue
Copy link
Member

tracking apparent regression at scala/bug#12868

@SethTisue
Copy link
Member

revert PR #1256

cwienberg referenced this pull request in cwienberg/spark-sorting-helpers Sep 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.4` -> `1.9.6` |

---

### Release Notes

<details>
<summary>sbt/sbt (sbt/sbt)</summary>

### [`v1.9.6`](https://togithub.com/sbt/sbt/releases/tag/v1.9.6): 1.9.6

[Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.5...v1.9.6)

#### bug fix

- sbt 1.9.6 reverts "internal representation of class symbol names"
change
([https://github.com/sbt/zinc/pull/1244](https://togithub.com/sbt/zinc/pull/1244)),
which caused Scala compiler to generate wrong anonymous class name by
[@&#8203;eed3si9n](https://togithub.com/eed3si9n) in
[https://github.com/sbt/zinc/pull/1256](https://togithub.com/sbt/zinc/pull/1256).
See
[https://github.com/scala/bug/issues/12868](https://togithub.com/scala/bug/issues/12868)
for more details.

**Full Changelog**: sbt/sbt@v1.9.5...v1.9.6

### [`v1.9.5`](https://togithub.com/sbt/sbt/releases/tag/v1.9.5): 1.9.5

[Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.4...v1.9.5)

#### highlights

- Switches to pre-compiled compiler bridge for Scala 2.13.12+
[#&#8203;7374][7374] by [@&#8203;eed3si9n][@&#8203;eed3si9n]
- Fixes NPE when just `-X` is passed to `scalacOptions`
[zinc#1246][zinc1246] by [@&#8203;unkarjedy][@&#8203;unkarjedy]

#### other updates

- Fixes internal representation of class symbol names
[zinc#1244][zinc1244] by [@&#8203;dwijnand][@&#8203;dwijnand]
- Fixes `NumberFormatException` in `CrossVersionUtil.binaryScalaVersion`
[lm#426][lm426] by [@&#8203;HelloKunal][@&#8203;HelloKunal]
- Fixes `scripted` client/server instability on Windows
[#&#8203;7087][7087] by [@&#8203;mdedetrich][@&#8203;mdedetrich]
- Fixes `sbt` launcher script bug on Windows [#&#8203;7365][7365] by
[@&#8203;JD557][@&#8203;JD557]
- Fixes `help` command on oldshell [#&#8203;7358][7358] by
[@&#8203;azdrojowa123][@&#8203;azdrojowa123]
- Adds `allModuleReports` to `UpdateReport` [lm#428][lm428] by
[@&#8203;mdedetrich][@&#8203;mdedetrich]
- Handles javac warning messages [zinc#1228][zinc1228] by
[@&#8203;Arthurm1][@&#8203;Arthurm1]
- Enables inliner for Scala 2.13 compiler bridge [zinc#1247][zinc1247]
by [@&#8203;mdedetrich][@&#8203;mdedetrich]

#### new contributors

- [@&#8203;azdrojowa123](https://togithub.com/azdrojowa123) made their
first contribution in
[https://github.com/sbt/sbt/pull/7358](https://togithub.com/sbt/sbt/pull/7358)
- [@&#8203;JD557](https://togithub.com/JD557) made their first
contribution in
[https://github.com/sbt/sbt/pull/7367](https://togithub.com/sbt/sbt/pull/7367)

**Full Changelog**: sbt/sbt@v1.9.4...v1.9.5

[@&#8203;eed3si9n]: https://togithub.com/eed3si9n

[@&#8203;Nirvikalpa108]: https://togithub.com/Nirvikalpa108

[@&#8203;adpi2]: https://togithub.com/adpi2

[@&#8203;er1c]: https://togithub.com/er1c

[@&#8203;eatkins]: https://togithub.com/eatkins

[@&#8203;dwijnand]: https://togithub.com/dwijnand

[@&#8203;mdedetrich]: https://togithub.com/mdedetrich

[@&#8203;JD557]: https://togithub.com/JD557

[@&#8203;azdrojowa123]: https://togithub.com/azdrojowa123

[@&#8203;HelloKunal]: https://togithub.com/HelloKunal

[@&#8203;unkarjedy]: https://togithub.com/unkarjedy

[@&#8203;Arthurm1]: https://togithub.com/Arthurm1

[7374]: https://togithub.com/sbt/sbt/pull/7374

[7087]: https://togithub.com/sbt/sbt/pull/7087

[7365]: https://togithub.com/sbt/sbt/issues/7365

[7358]: https://togithub.com/sbt/sbt/pull/7358

[zinc1246]: https://togithub.com/sbt/zinc/pull/1246

[zinc1244]: https://togithub.com/sbt/zinc/pull/1244

[zinc1228]: https://togithub.com/sbt/zinc/pull/1228

[zinc1247]: https://togithub.com/sbt/zinc/pull/1247

[lm426]: https://togithub.com/sbt/librarymanagement/pull/426

[lm428]: https://togithub.com/sbt/librarymanagement/pull/428

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zinc reports incorrect class file names
5 participants