Use ConcurrentHashMap
in Stamp.scala
#1317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The two
synchronized
locks inStamp.scala
sometimes take too long to be grabbed (#1129)Mitigation
Not sure about the root cause of the issue. But we can at least make lock more granular via using
ConcurrentHashMap
instead ofsynchronized
.As bonus this change addresses a potential race condition. When
InitialStamps.source
andInitialStamps.getAllSourceStamps
is called concurrently, the access is not thread-safe. Such access pattern is probably very rare / never happens in practice, but nonetheless an improvement that it is addressed.